Open michaelzs85 opened 4 years ago
Hey @shurillu, I would really like some feedback on the pull-request. If the whole pull-request is to big I will try to split it into smaller parts - let me know!
Hello michaelzs85, thank you for the great work that you are doing. Sadly those days are very busy and I didn't find the time to check the pull request. So please give me some more time to review the pull request. A thing that I want to modify is keep the backward compatibility (maybe with stub member function). Stefano
Hello michaelz85, finally I found the time to examine all your excellent work, well done. I made a new branch named ESP32_Support. I made some changes:
Speaking about the use of fingerprint in ESP32 platform. If I remember well, the fingerprint is a trick used in ESP8266 platform to check the https connection because the ESP8266 low resources can't do the "standard https job". ESP32 platform have plenty resources (compared to ESP8266) so I guess this platform don't need it.
So, thank you very much for all you did (I planned several years ago to support ESP32 and now, with your work it comes possible!) and if you want to continue to help me, you are welcome!!
Stefano
P.S.: if you want, I'll put your name in the special thanks section.
#define CTBOT_BOARD 8266
in CTBotDefines.h to#define CTBOT_BOARD 32
-DCTBOT_BOARD=32
while compiling