search

shurunxuan / IGME-601-2181-Team-C

1 stars 0 forks source link

Camera refactor #50

Closed shurunxuan closed 5 years ago

shurunxuan commented 5 years ago

OK, so apparently I did something very wrong so that I have to get rid of the old branch and PR. It was my first time to actually revert commits and I overdid it and the branch is broken.

https://trello.com/c/awxhl7Mv/65-camera-movement-refactor-2-points

Story to be tested: Camera & Movement Refactor

Functionality:

Though this is said to be a refactor for both camera and movement, I'm still calculating how the new drone can fly in a stable state, and this will take some time. This PR is only for the new camera system. This is the best solution I can think of after experimenting with different kind of cameras. When the object - the drone, or the camera itself entered a narrow space, it will be toggled into the first-person mode. The only thing I worry about is this toggle happens too often which is annoying. I'll continue researching this.

Procedure:

  1. Open Assets\Scenes\DemoScenes\Sprint4DemoScene.unity
  2. Play through the scene.
  3. Do something bad with the camera. Observe the behavior.
shurunxuan commented 5 years ago

I fixed the bug we found during the meeting. However the Sprint4DemoScene on my computer is good, and I have no idea why others' are broken. I'll try to solve this.

shurunxuan commented 5 years ago

And I think we might need a new, clean scene...

shurunxuan commented 5 years ago

Figured out. I accidentally use the 2018.3.0f version and it updated the scene which is not compatible with 2018.2.xf versions.

You should be able to test the camera thoroughly.