search

shusaura85 / fancourier-api

PHP library to work with the new Fan Courier API v2.0 (selfawb.ro / api.fancourier.ro)
MIT License
21 stars 9 forks source link

Bad limit in setter #9

Closed romanpiller closed 6 months ago

romanpiller commented 6 months ago

There is limit to 100 for perPage in Request/getStreets. When I set the limit to 1000, it returned 1000 objects of street. Just as the documentation says.

shusaura85 commented 6 months ago

Tried it out and confirmed working now.
When I implemented it, it wouldn't work with more than 100, probably due to the way I sent requests prior to v2.0.4.
Update coming up to fix the limit. Thanks to this, I also found a forgotten multiple return type in the Street object that doesn't work with php 7.0