shutter-network / rolling-shutter

Rolling Shutter is an MEV protection system to be plugged into rollups.
https://twitter.com/project_shutter/
26 stars 7 forks source link

Introduce consistent line-length code formatter in pre-commit hook #395

Open ezdac opened 10 months ago

ezdac commented 10 months ago

The gofmt (and gofumpt) code formatter do not want to enforce a particular line length. However, I think we should introduce this for our project as a pre-commit hook. There is golines, which defaults to a maximum of 100 columns per line, but is configurable.

Are there any other opinions about this?

schmir commented 10 months ago

396 uses the golines-gofumpt hook with 120 characters line length limit

jannikluhn commented 1 month ago

golanci-lint enforces a line length limit, but we only run it in CI (via make lint-changes) not as a pre-commit hook.