search

shutter-network / rolling-shutter

Rolling Shutter is an MEV protection system to be plugged into rollups.
https://twitter.com/project_shutter/
28 stars 9 forks source link

Upgrade go-ethereum to match shlib's version #422

Open konradkonrad opened 10 months ago

konradkonrad commented 10 months ago

shlib/v0.1.14 uses go-ethereum@v1.13.4.

This PR has the change in isolation, so we can debug any incompatibilities as a prerequisite for merging #416

I found the following potential breaking change:

konradkonrad commented 10 months ago

Here's the node output from one of the play tasks (play/work/keyper-dkg-works/logs/node-out.txt)

  Block #17:           0xd8b55cefae9a214872c70d75a71d10d37add805c5f28ac933323b9f8aeebf9f9
  Contract call:       CollatorConfigsList#getActiveConfig
  From:                0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266
  To:                  0x8a791620dd6260079bf849dc5567adc3f2fdc318
  Contract call:       CollatorConfigsList#addNewCfg
  Transaction:         0x7de10378070e03911730394d909ecb411f3bfb99349d909d27bb4e7c58c4be8d
  From:                0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266
  To:                  0x8a791620dd6260079bf849dc5567adc3f2fdc318
  Value:               0 ETH
  Gas used:            66543 of 29021656
  Block #18:           0x8965130a9a72ca673c58ffb4a89e16b937809e499684ef1f064c29878824cb01

eth_blockNumber
eth_getLogs
eth_getLogs (2)
eth_blockNumber
eth_call
  Contract call:       AddrsSeq#<unrecognized-selector>
  From:                0x0000000000000000000000000000000000000000
  To:                  0xdc64a140aa3e981100a9beca4e685f962f0cf6c9

  Error: Transaction reverted: function selector was not recognized and there's no fallback nor receive function
      at AddrsSeq.<unrecognized-selector> (src/AddrsSeq.sol:21)
      at processTicksAndRejections (node:internal/process/task_queues:95:5)
      at HardhatNode.runCall (/home/konrad/Projects/rolling-shutter/contracts/node_modules/hardhat/src/internal/hardhat-network/provider/node.ts:665:20)
      at EthModule._callAction (/home/konrad/Projects/rolling-shutter/contracts/node_modules/hardhat/src/internal/hardhat-network/provider/modules/eth.ts:356:9)
      at HardhatNetworkProvider._sendWithLogging (/home/konrad/Projects/rolling-shutter/contracts/node_modules/hardhat/src/internal/hardhat-network/provider/provider.ts:144:22)
      at HardhatNetworkProvider.request (/home/konrad/Projects/rolling-shutter/contracts/node_modules/hardhat/src/internal/hardhat-network/provider/provider.ts:121:18)
      at JsonRpcHandler._handleRequest (/home/konrad/Projects/rolling-shutter/contracts/node_modules/hardhat/src/internal/hardhat-network/jsonrpc/handler.ts:191:20)
      at JsonRpcHandler._handleSingleRequest (/home/konrad/Projects/rolling-shutter/contracts/node_modules/hardhat/src/internal/hardhat-network/jsonrpc/handler.ts:152:17)

eth_getLogs
eth_getLogs (2)
eth_blockNumber
eth_getLogs
eth_getLogs (2)
eth_blockNumber
eth_blockNumber (2)
eth_blockNumber (3)
eth_getLogs
eth_getLogs (2)
eth_blockNumber
eth_getLogs
eth_call
  Contract call:       AddrsSeq#<unrecognized-selector>
  From:                0x0000000000000000000000000000000000000000
  To:                  0xdc64a140aa3e981100a9beca4e685f962f0cf6c9

  Error: Transaction reverted: function selector was not recognized and there's no fallback nor receive function
      at AddrsSeq.<unrecognized-selector> (src/AddrsSeq.sol:21)
      at processTicksAndRejections (node:internal/process/task_queues:95:5)
      at HardhatNode.runCall (/home/konrad/Projects/rolling-shutter/contracts/node_modules/hardhat/src/internal/hardhat-network/provider/node.ts:665:20)
      at EthModule._callAction (/home/konrad/Projects/rolling-shutter/contracts/node_modules/hardhat/src/internal/hardhat-network/provider/modules/eth.ts:356:9)
      at HardhatNetworkProvider._sendWithLogging (/home/konrad/Projects/rolling-shutter/contracts/node_modules/hardhat/src/internal/hardhat-network/provider/provider.ts:144:22)
      at HardhatNetworkProvider.request (/home/konrad/Projects/rolling-shutter/contracts/node_modules/hardhat/src/internal/hardhat-network/provider/provider.ts:121:18)
      at JsonRpcHandler._handleRequest (/home/konrad/Projects/rolling-shutter/contracts/node_modules/hardhat/src/internal/hardhat-network/jsonrpc/handler.ts:191:20)
      at JsonRpcHandler._handleSingleRequest (/home/konrad/Projects/rolling-shutter/contracts/node_modules/hardhat/src/internal/hardhat-network/jsonrpc/handler.ts:152:17)
bilbeyt commented 10 months ago

We need https://github.com/NomicFoundation/hardhat/pull/4438 to be released to support this newer version.

konradkonrad commented 3 months ago

It seems https://github.com/NomicFoundation/edr/pull/444 did fix this incompatibility.