Investigate key generation performance

shutter-network / rolling-shutter

Rolling Shutter is an MEV protection system to be plugged into rollups.

https://twitter.com/project_shutter/

26 stars 7 forks source link

Investigate key generation performance #452

Open jannikluhn opened 3 weeks ago

jannikluhn commented 3 weeks ago

During key generation, the following steps might take a non-negligible amount of time:

event syncing from the chain
computing the decryption key share
broadcasting decryption key share
validating decryption key shares
aggregating shares to get the decryption keys
broadcasting decryption keys
validating decryption keys

We should investigate how much time each of those steps take when there's few or many keys to produce. We should also check if there's potentially other steps missing in this list. As a result, we will know where to look for optimization potential.

jannikluhn commented 2 weeks ago

Here's some real world timing measurements of message validation and handling during a stress test: https://gist.github.com/konradkonrad/b3c6157bfb9170ecce29df7cf35203e5

Most extreme lines:

2024/06/12 07:13:55.653711 DBG [     messaging.go:40] validated message duration=302.575809ms topic=decryptionKeyShares
2024/06/12 07:13:55.808521 DBG [    messaging.go:304] handled message duration=366.220828ms message-name=p2pmsg.DecryptionKeyShares
2024/06/12 07:13:57.143916 DBG [     messaging.go:40] validated message duration=769.346693ms topic=decryptionKeys
2024/06/12 07:13:57.167785 DBG [    messaging.go:304] handled message duration=21.959567ms message-name=p2pmsg.DecryptionKeys

So it appears the issue is in message validation and handling, not in chain syncing or network propagation.

konradkonrad commented 2 weeks ago

https://github.com/shutter-network/rolling-shutter/blob/12fcea966efe7a2772cc9d8a7860600aece47a64/rolling-shutter/medley/testkeygen/keygen_test.go#L82

go test -bench=. ./medley/testkeygen -cpuprofile profile.out
goos: linux
goarch: amd64
pkg: github.com/shutter-network/rolling-shutter/rolling-shutter/medley/testkeygen
cpu: Intel(R) Core(TM) i5-8350U CPU @ 1.70GHz
BenchmarkKeyperComputeSecretShares-8          22      52727480 ns/op
BenchmarkSecretKeyGeneration-8                33      36374355 ns/op
BenchmarkFullBlock-8                           2     815570668 ns/op
PASS
ok      github.com/shutter-network/rolling-shutter/rolling-shutter/medley/testkeygen    116.344s

flame