search

shutterfly / easytest-core

The core module of EasyTest Framework. This includes the core classes for performing Data Driven Testing in Java
0 stars 0 forks source link

refactor approach to loading JSON from CSV files so that ampersand and single-quote characters are respected #1

Closed skuenzli closed 10 years ago

skuenzli commented 10 years ago

Refactor approach to loading JSON from CSV files so that ampersand and single-quote characters are respected. Since bc5e3d47 the single-quote and ampersand characters have been replaced with double-quote and comma, respectively.

This behavior blocks our ability to upgrade from EasyTest 0.8 to 1.3.x because we have a number of csv data files that use the ampersand character (&):

skuenzli commented 10 years ago

Refactored JSON-support out of CSVDataLoader and into a CSV-JSON-specific Loader.

  1. Moved value normalization that is specific to JSON into CSVJSONDataLoader
  2. Connected all the creation Loader creation bits
    1. add tests for LoaderFactory
    2. add tests for file extension -> LoaderType resolution
  3. Added a test that verifies characters are supported for CSV per rules of rfc4180