search

shutterstock / rickshaw

JavaScript toolkit for creating interactive real-time graphs
https://shutterstock.github.io/rickshaw
MIT License
6.53k stars 941 forks source link

Running samples in IE9 produces JS errors #2

Closed pranavkm closed 12 years ago

pranavkm commented 12 years ago

SCRIPT5007: Unable to set value of the property 'Color': object is null or undefined rickshaw.min.js, line 1 character 3349

SCRIPT5007: Unable to get value of the property 'Palette': object is null or undefined colors.html, line 44 character 2

Haven't debugged it thoroughl, but it seems to stem from the namespacing function.

namespace: function(namespace, obj) { 

    var parts = namespace.split('.');
    parent = Rickshaw; // At this point, it's trying to assign the value to window.parent which no-ops. declaring it as a local variable should do the right thing.
itay commented 12 years ago

Just ran into this as well.

erikdahlstrom commented 12 years ago

This is probably the same as https://github.com/shutterstock/rickshaw/issues/1.

skellytt commented 12 years ago

Is there a fix for IE?

dchester commented 12 years ago

This should be fixed with commit 4bb198518a25b0707756a714b6f76fff948e64cf