shutterstock / rickshaw

JavaScript toolkit for creating interactive real-time graphs
https://shutterstock.github.io/rickshaw
MIT License
6.53k stars 941 forks source link

AngularJS example #585

Closed cesine closed 7 years ago

cesine commented 7 years ago

This example shows how to balance the redraw of dom elements between frameworks like angular and d3.

screen shot 2017-08-01 at 9 10 40 pm

Based on:

For a generic angular directive with deep watchers use https://github.com/ngyewch/angular-rickshaw

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.06%) to 62.874% when pulling 07490c7ea5b0545fea5d5876016209372c369edf on cesine:angular into 0aff8dd17cf08b2d730f74cc21ceeb506761f435 on shutterstock:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.06%) to 62.874% when pulling 35b19f0701f8457ada14c068c384b3810bb5b42d on cesine:angular into 0aff8dd17cf08b2d730f74cc21ceeb506761f435 on shutterstock:master.

RichardLitt commented 7 years ago

Looks like you forgot to check in after running npm run build. Once I've done that, the example seems to work fine.

I would add a test for setSeries.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.06%) to 62.874% when pulling 2dcdd626c3b19e8e0f620eebb22d4a1f378c0af4 on cesine:angular into 0aff8dd17cf08b2d730f74cc21ceeb506761f435 on shutterstock:master.

RichardLitt commented 7 years ago

LGTM!