shutterstock / rickshaw

JavaScript toolkit for creating interactive real-time graphs
https://shutterstock.github.io/rickshaw
MIT License
6.53k stars 939 forks source link

Fix for: Gulp build wasn't injecting rickshaw file #597

Closed conanza closed 6 years ago

conanza commented 6 years ago

specify js file extension for main property in bower spec and pull in rickshaw.css

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 62.814% when pulling 09ece84e772bbe4182d4d35ec074e6afd91309a4 on Conanza:fix-for-build-tools into 690ca1342486202082c63901b2837c6271f44b79 on shutterstock:master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 62.814% when pulling 0e25e4102fdf2f20966ba6c3ec2dc8497cf36ce9 on Conanza:fix-for-build-tools into 690ca1342486202082c63901b2837c6271f44b79 on shutterstock:master.

RichardLitt commented 6 years ago

This looks correct according to the bower main manifest.

Is anyone else able to confirm this, before merge?

RichardLitt commented 6 years ago

@aendrew made a similar PR in https://github.com/shutterstock/rickshaw/pull/465/files. I am going to merge this as accurate.