shutterstock / rickshaw

JavaScript toolkit for creating interactive real-time graphs
https://shutterstock.github.io/rickshaw
MIT License
6.53k stars 939 forks source link

fix: check undefined for series opacity #616

Closed conanza closed 4 years ago

conanza commented 6 years ago

If we expect opacity to be a number, when series.opacity = 0, these ternaries would be falsey and set series.opacity to 1 by default. Check to see if opacity property is defined or not instead.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 62.953% when pulling 70a9a31d6f5797b5a96a1f8cf29f03bed98406c3 on Conanza:series-opacity-check into 592fa14b30b785e0e53a618c148d250724eea67c on shutterstock:master.