search

shuttle-hq / shuttle

Build & ship backends without writing any infrastructure files.
https://shuttle.rs
Apache License 2.0
6.08k stars 250 forks source link

[Improvement]: bump sqlx to 0.8.2 #1863

Closed nicolasauler closed 2 weeks ago

nicolasauler commented 2 months ago

Describe the improvement

This will allow consumers of the crate to update to the latest sqlx. Also, sqlx <= 0.8.0 has a reported security vulnerability, and the fix is at 0.8.1.

Duplicate declaration

nicolasauler commented 2 months ago

I'm also onboard for helping solve this issue, as I'm an interested party. I just never opened a PR on this repo and maybe could use some guidance, although from what I've seen the Contribution and Developing guides are quite thorough.

jonaro00 commented 2 months ago

Thanks for giving attention to this. It's an easy change to make: Bump the version in the shared db and AWS RDS crates, and make sure they compile. After that works, all examples using it can be updated.

jonaro00 commented 2 months ago

I forgot that we already did this in https://github.com/shuttle-hq/shuttle/pull/1847. What we can do now that 0.8.1 is released is to bump it again. There is a bug in 0.8.1 that will make it not compile on Rust < 1.80 which our CI uses, but we can ignore that (just run the CI command locally with 1.80).

GnomedDev commented 1 month ago

Seems like sqlx dep has already been bumped, and all that is needed is a new breaking release of shuttle-shared-db.

jonaro00 commented 1 month ago

Yep, solved in #1867. Awaiting release.

joshua-mo-143 commented 2 weeks ago

SQLx has been bumped to 0.8.2 on shuttle-shared-db 0.48.0! You should now be unblocked from this.

nicolasauler commented 2 weeks ago

Thanks a lot, my friends! Closing issue as resolved.