search

shuttle-hq / synth

The Declarative Data Generator
https://www.getsynth.com/
Apache License 2.0
1.39k stars 109 forks source link

Integrate rustfmt #206

Closed hbina closed 3 years ago

hbina commented 3 years ago

Closes https://github.com/getsynth/synth/issues/92

  1. Not sure what's the best way to share this git-hook? For now its just in git-hooks so if you want to use it just copy it over.
  2. I am not sure how to test the CI script...
  3. Use prettier for everything else? :)
brokad commented 3 years ago

LGTM, thanks @hbina!

As to your points:

1. Not sure what's the best way to share this git-hook? For now its just in `git-hooks` so if you want to use it just copy it over.

Can we move this to tools/hooks maybe? In order to prevent adding yet another top-level directory. For sharing it, we could add a simple instruction in CONTRIBUTING.md to configure hooks with git config core.hooksPath tools/hooks.

2. I am not sure how to test the CI script...

The easiest at this point is to open a PR against your fork's master. It should all work out of the box. That being said, it would be nice if we managed to drive the tests run in the GH CI in cargo test instead, as this would make it easier to run them locally.

3. Use prettier for everything else? :)

I don't have any experience with prettier, but I know of it and I am on board! :smile:

christos-h commented 3 years ago

I'm on rebasing this.