search

shuttle-hq / synth

The Declarative Data Generator
https://www.getsynth.com/
Apache License 2.0
1.37k stars 108 forks source link

refactor: remove `Name` struct #261

Closed bmoxb closed 2 years ago

bmoxb commented 2 years ago

Removes the schema::Name struct entirely. Use regular String instead, with necessary checks in place to prevent invalid names. Also made some minor changes to Namespace to make it a little bit nicer to work with.

Minor issue: potentially invalid names could be put into a Namespace due to the fact that it implements FromIterator - I'm not aware of a fallible version of that trait that could be used instead?

brokad commented 2 years ago

Thanks @WiredSound, I am happy to see Name disappear :smile: