search

shuttle-hq / synth

The Declarative Data Generator
https://www.getsynth.com/
Apache License 2.0
1.37k stars 107 forks source link

fix: treat camelcase table names in prostgresql properly #390

Closed mhorbul closed 1 year ago

mhorbul commented 1 year ago

addresses https://github.com/shuttle-hq/synth/issues/389

mhorbul commented 1 year ago

The import test is failing due to its random nature of it. I am not sure how to fix that one.

iamwacko commented 1 year ago

The randomness is seeded, so this shouldn't really be happening. We might just have to change the golden copy located here. You also might want to remember to run cargo fmt before you commit.

mhorbul commented 1 year ago

The randomness is seeded, so this shouldn't really be happening. We might just have to change the golden copy located here. You also might want to remember to run cargo fmt before you commit.

my bad, addressed both fmt and clippy

iamwacko commented 1 year ago

You might have to rename hospitals.json to Hospitals.json, as tables are represented by collections.

mhorbul commented 1 year ago

You might have to rename hospitals.json to Hospitals.json, as tables are represented by collections.

I did it locally, but git for some reason did not catch that change. Now renamed it for realz.