Closed moore-ryan closed 1 year ago
If I have some time this weekend, I'll look at implementing a fix - should be pretty straightforward, just need to fall-through to the serde_json::Value::String
case if unwrapping the float value fails.
Thanks for putting the time in to report an error and find the issue. If you find you don't have time I can work on this, but otherwise I'll be waiting for your PR.
Describe the bug When importing from CSV, if any of the CSV cells have the string
Nan
present, then the CSV import will panic due to attempting to unwrap an invalid conversion incsv_str_to_value
To Reproduce Steps to reproduce the behavior:
Example file:
test/test.csv
Run command
See error
Expected behavior CSV files which have the string
Nan
present in them should not panic. Depending on the context,Nan
is a valid value for CSV columns (e.g. for a person's name). If the first non-header row intest.csv
is changed to beNand,Jones
, then a panic no longer appears.Environment (please complete the following information):