shuyangk / pe

0 stars 0 forks source link

Unable to update a localcourse that is mapped to a partner course #10

Open shuyangk opened 11 months ago

shuyangk commented 11 months ago

When attempting to update a localcourse that is currently mapped, the application disallows this, and the mapping has to be deleted first. However this might cause inconvenience for users if the course to be updated is mapped to many other courses, and they have to delete all mappings before being able to update the local course. Maybe updating a local course that is mapped to other courses should be allowed, and the mapping itself should be updated by the application.

image.png

nus-pe-bot commented 11 months ago

Team's Response

One of our planned enhancements: Add the ability to allow update of mappings, to complement the existing mapping feature. This was not prioritised due to time constraints.

To update a mapped local course code / partner course code (the primary keys), we have to update the corresponding code in the mappings (foreign key) too which falls under 'updating of mapping'.

We only allow updating of local name, local unit and local description of local courses.

Due to planned enhancements, this was intended, or else it will cause other bugs related to updating of mapping.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: From the planned enhancements stated in the DG, it is interpreted as allowing updates to the mappings, (i.e editing of mappings), since the ability to edit mappings is currently not present. However this issue is related to the updating of local courses, which is a separate action from changing the mappings. The way the planned enhancement was stated is not clear to the reader who is only reading the DG for information.

image.png