shuyangk / pe

0 stars 0 forks source link

Branch node does not follow course standards #15

Open shuyangk opened 10 months ago

shuyangk commented 10 months ago

In the course, it is mentioned that branch nodes should be empty inside, with branch conditions written on the outside, however the below activity diagram violates this.

image.png

nus-se-bot commented 10 months ago

Team's Response

Does not hinder the user, doesn't affect usage as it doesn't change the meaning. (another notation)

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: While if simply a standalone notation error, it might fall under the VeryLow categorization, however according to the guidelines, notation errors can hurt the credibility of diagrams, and as there are multiple separate notation errors across various diagrams, I believe the severity should be Low.

image.png