shuyangk / pe

0 stars 0 forks source link

Note update allows note content to become the same as an existing note. #8

Open shuyangk opened 10 months ago

shuyangk commented 10 months ago

As shown below, the content of notes 6 and 7 are now identical after using the note update command. This defeats the earlier purpose of add note checking for content being identical, perhaps this check should be added to this command as well!

image.png

Added command executed below:

image.png

nus-pe-bot commented 10 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Duplicate note

image.png

While stated that you cannot create duplicate notes in the UG (and you can't with note add), you can still add a note then note update it to have the same content as another note.

Steps taken to get bug:

  1. note add [You can do this!] [motivation]
  2. note add [You can do this] [motivation]
  3. note update [1] [You can do this]

[original: nus-cs2103-AY2324S1/pe-interim#2436] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

While we do specify that user cannot add duplicated content using note add command, there is no restriction on how you can update the note content for now as this does not affect the user experience.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.NotInScope`] - [x] I disagree **Reason for disagreement:** The behaviour of the application contradicts the stated behaviour in the User guide, specifically the part about 'You cannot have two notes of the same content'. Hence this is within scope. ![image.png](https://raw.githubusercontent.com/shuyangk/pe/main/files/17ecfd79-43b9-40de-8f9f-3ec1ed82adce.png)
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]