search

shuzhao-li-lab / asari

asari, metabolomics data preprocessing
Other
41 stars 10 forks source link

Remove __hacked_lowess__ in future version #30

Closed shuzhao-li closed 1 year ago

shuzhao-li commented 1 year ago

__hacked_lowess__ was used as a hack to fix bug in statsmodels.

statsmodels.nonparametric.smoothers_lowess, v 0.12, 0.13+ https://www.statsmodels.org/stable/generated/statsmodels.nonparametric.smoothers_lowess.lowess.html
But xvals have to be forced as float array until the fix is in new release.

The fixed version is out now, but people may have older versions on their computers. We will wait a couple of asari releases before removing this function.

jmmitc06 commented 1 year ago

There is now a check to ensure that a compatible version of statsmodels is present and if so, __hacked_lowes__ is not used. I'm going to save complete removal for a few versions at least.