shwenzhang / AndResGuard

proguard resource for Android by wechat team
Apache License 2.0
8.54k stars 1.54k forks source link

jarsigner 调用方式太过简陋 #81

Closed xen0n closed 8 years ago

xen0n commented 8 years ago

问题代码

遇到密码或密钥别名中含有空格等字符的情况,Gradle 就会崩溃,这里应该对传入参数进行转义处理。

(一周后可写补丁,现在比较忙,不好写

simpleton commented 8 years ago

这里写的是有点偷懒,多谢反馈

2016-07-21 1:52 GMT+08:00 Wang Xuerui notifications@github.com:

问题代码 https://github.com/shwenzhang/AndResGuard/blob/master/AndResGuard-core/src/main/java/com/tencent/mm/androlib/ResourceApkBuilder.java#L107-L112

遇到密码或密钥别名中含有空格等字符的情况,Gradle 就会崩溃,这里应该对传入参数进行转义处理。

(一周后可写补丁,现在比较忙,不好写

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/shwenzhang/AndResGuard/issues/81, or mute the thread https://github.com/notifications/unsubscribe-auth/AAbvYo_6Nh-Zs8WCk5NlbZrDFYfxpVm0ks5qXmBngaJpZM4JRCWB .

xen0n commented 8 years ago

@simpleton 突然发现根本不用转义,直接构造argv就行了,因此PR已开 😄

xen0n commented 8 years ago

卧槽,GitHub web提交PR界面好蠢,默认提交到自己的fork。。。这次确实提交了

simpleton commented 8 years ago

ref #93