search

shweshi / OpenGraph

A Laravel package to fetch Open Graph data of a website.
https://opengraph.shashi.dev
MIT License
152 stars 29 forks source link

Problem to get meta image #77

Open MirianBebee opened 3 years ago

MirianBebee commented 3 years ago

Good Morning,

I'm writing you because I have had a bug when obtaining the openGraph of a url, it does not get the image because it has escaped characters and it is not validated.

When using openGraph there are certain urls from which the image is not obtained correctly, and it is because a decode of the image should be added in the verify_image_url function.

Page example: https://www.forbes.com/sites/forbescoachescouncil/2017/04/19/networking-or-job-boards-nine-strategies-to-find-your-next-role/

Image url: https://thumbor.forbes.com/thumbor/fit-in/1200x0/filters%3Aformat%28jpg%29/https%3A%2F%2Fblogs-images.forbes.com%2Fforbescoachescouncil%2Ffiles%2F2017%2F04%2FNetworking-or-Job-Boards-Nine-Strategies-To-Land-Your-Next-Role.jpg

Solution: $url = urldecode ($url);

Thanks in advance,

Mirian

shweshi commented 3 years ago

@MirianBebee Thanks for pointing out problem and proposing the solution. This certainly may cause the issue, and I think the proposed solution should work. If you don't mind, I will encourage you to open a pull request with the proposed solution and contribute to improve the OpenGraph.

Thanks.