search

shweshi / terminal-stocks

terminal-stocks is a terminal based application that provide stock price information.
https://blog.shashi.dev/2021/01/track-stock-market-information-right-in.html
MIT License
61 stars 9 forks source link

Tickers don't seem to work. #15

Closed andriy-git closed 1 year ago

andriy-git commented 1 year ago

Most things I try seem to work fine. For example:

So I am a little puzzled why VUSTX doesn't. Is there something special about this specific ticker or how Yahoo handles it? I am currently using curl terminal-stocks version.

chris-hmmr commented 1 year ago

Hi @andriy-git, looks to be some issue with a null reference. I'll look into it.

chris-hmmr commented 1 year ago

Hi @andriy-git, I fixed the issue and created a new release. It looks like not all tickers provide the same data. VUSTX for example does not provide data on "Day Range", which was unaccounted for.

image

Should be find now.

Cheers, Christopher

andriy-git commented 1 year ago

@chris-hmmr so before it would of not picked up mutual funds. Mutual funds only post ends of day price and do not have a day range. Thank you very much for the fix. You do a fantastic job.

andriy-git commented 1 year ago

Hey @chris-hmmr , it seems like VUSTX is again not showing anything.

chris-hmmr commented 1 year ago

Hi @andriy-git, thanks for reaching out. I am aware of the issue. I am currently rewriting the code because Yahoo is changing their encryption algorithm on the data every other week. Looking into a more permanent solution.

I will let you know when I have a fix ready.

Cheers, Christopher

chris-hmmr commented 1 year ago

Hi @andriy-git, I just updated the website for the fix. Should be good now, please have a look for yourself.

curl https://terminal-stocks.dev/VUSTX

Cheers, Christopher

chris-hmmr commented 1 year ago

Was fixed in https://github.com/shweshi/terminal-stocks/commit/5405d9c937490596a84532f1a073fe9f010f83aa