search

shweshi / terminal-stocks

terminal-stocks is a terminal based application that provide stock price information.
https://blog.shashi.dev/2021/01/track-stock-market-information-right-in.html
MIT License
61 stars 9 forks source link

Broken API #19

Closed shweshi closed 6 months ago

shweshi commented 6 months ago

curl https://terminal-stocks.dev/market-summary is returning.

Sorry, we couldn't find. Please check the stock ticker and provide correct one. Invalid Crumb. For Developers - https://bit.ly/yahoo-finance-api-feedback

Same for other APIs with stock tickers.

shweshi commented 6 months ago

@chris-hmmr looks like something has changed from Yahoo API.

chris-hmmr commented 6 months ago

Hi @shweshi, yes, it seems Yahoo is curtailing API access. I shall investigate if there is a way to circumvent or fix this.

chris-hmmr commented 6 months ago

Looks like the issue on the dependent library has been resolved, see here. I'll update the package and check locally if that fixes our issue as well.

chris-hmmr commented 6 months ago

Hi @shweshi, I opened a PR with a fix https://github.com/shweshi/terminal-stocks/pull/20/files. Please review.

shweshi commented 6 months ago

@chris-hmmr merged thanks.

chris-hmmr commented 6 months ago

@shweshi you're welcome. Bugfix is now live terminal-stocks.dev/AAPL

image