search

shyakadavis / geist

Svelte implementation of the Geist Design System by Vercel. (WIP)
https://geist.shyakadavis.me/
62 stars 6 forks source link

feat: add icons page #15

Closed ddtamn closed 2 months ago

shyakadavis commented 2 months ago

Hello, @ddtamn

Thank you for the P.R.

In the spirit of mirroring the original, I was wondering if we could add more features, like the context menu, icon names...

If you are busy at the moment, then with your permission, I could help by committing directly to this P.R.

What do you think?

Thanks again.

ddtamn commented 2 months ago

Hello, @shyakadavis

Thank you for your feedback.

I completely agree with your suggestion to add more features, such as the context menu and icon names. I am currently a bit busy, but I will try to make some commits when I have free time. However, you are welcome to commit directly to this P.R. if needed.

Thanks again!

github-actions[bot] commented 2 months ago
built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
geist ✅ Ready (View Log) Visit Preview 39561e780feb80a4f6e5363e45b2d26442388263
shyakadavis commented 2 months ago

Hmm... the preview deployment is wrong. I'll keep investigating why it's not deploying the current branch with its changes.

shyakadavis commented 2 months ago

Could be related: https://github.com/huntabyte/shadcn-svelte/issues/1204 in that I'm using their workflows in order to get forked-repo previews.

shyakadavis commented 2 months ago

The correct deployment previews are now live. I wanted to add the search feature before merging, but IMO, good to go for now.