shyamtawli / devFind

devFind is an open source project that aims to create a platform for developers to showcase their skills and connect with potential collaborators, all in a user-friendly and searchable format.
https://dev-find.vercel.app/
MIT License
553 stars 586 forks source link

#982 Fix search bar #1080

Closed Priyal208 closed 4 months ago

Priyal208 commented 4 months ago

Description

As mentioned in issue #982 assigned to me under gssoc'24 , I optimised the search bar which earlier gave not so appropriate results making it more user friendly.

Related Issues

982

Changes Proposed

Additionaly I added a drop which allows users to select whether they want to serach by name, location or skill and then it gives specific results as per requirement only unlike earlier random results.

Checklist

Screenshots

Screenshot 2024-07-10 191035 Screenshot 2024-07-10 191050 Screenshot 2024-07-10 191107

Note to reviewers

Kindly review it asap and give me appropriate level as I also additionaly added dropdown bar and made it most optimized. Thank you

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dev-find ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 0:31am
Priyal208 commented 4 months ago

@shyamtawli kindly review it

akbatra567 commented 4 months ago

Hello @Priyal208, Could you look into this scenario ?

We have a search string

  1. kolkata,india
  2. kolkata, india Just a difference of space is a giving us different result.

Screenshot 2024-07-13 at 12 50 32 AM Screenshot 2024-07-13 at 12 50 15 AM

Issues with this is even if we have a match for the location, we won't be able to find if a comma or space is in different order. P.S: This is one scenario for location, do check for other filters as well.

Priyal208 commented 4 months ago

@shyamtawli now pls you can check i fixed that problem of space giving different result for all test cases You can see search queries before space and after space Screenshot 2024-07-15 185710 Screenshot 2024-07-15 185719

akbatra567 commented 4 months ago

Hey @shyamtawli, There is a scenario which doesn't work as of now:

Do you need this to be handle in this PR, or we can create a new issue for that.

Priyal208 commented 4 months ago

@shyamtawli can you pls review this

Priyal208 commented 4 months ago

@shyamtawli i did improve the UI u can see i added appropriate spacing, kindly merge the PR now, also pls see that you are assigning appropriate level as I did improve search operation, also added dropdown, even improved the UI Screenshot 2024-07-22 125314 Screenshot 2024-07-22 125322

shyamtawli commented 4 months ago

@Priyal208 Thank you so much for your contribution! Your efforts are greatly appreciated and will go a long way in improving our project. Please feel free to share it with others and help us grow even further!

Priyal208 commented 4 months ago

@shyamtawli sure thanks