search

shyamupa / snli-entailment

attention model for entailment on SNLI corpus implemented in Tensorflow and Keras
178 stars 43 forks source link

Bidirectional bug? #2

Open kudkudak opened 7 years ago

kudkudak commented 7 years ago

I think you should have added before this https://github.com/shyamupa/snli-entailment/blob/master/amodel.py#L101 a reverse lambda (see https://github.com/fchollet/keras/pull/3495/files for correct bidirectional lstm in keras) :)

shyamupa commented 7 years ago

ooh, did not know about this. thanks for the pointer.