search

shyanyong / pe

0 stars 0 forks source link

Not allowed to enter users whose names have hyphens. #5

Open shyanyong opened 11 months ago

shyanyong commented 11 months ago

When users with names that have hyphens are inputted, error message is shown. This should not be right as it is not uncommon for people to have legal names that have hyphens in them.

Steps to reproduce: addc n/name-with-hyphen p/1233 e/124@124.124

Expected behaviour: Correct user profile is created. Actual behaviour: error is shown.

image.png

nus-pe-script commented 11 months ago

Team's Response

Similar to #3264, this is not a major issue for our target users as the app is not intended to aid in any legal procedure. The remark field can be used to specify full names with hyphens if needed.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Name with slashes are not allowed when adding users.

When adding users where their name has a slash, program will show an error message. This is not right as there are many people whose names have "/" inside of it.

steps to recreate: add users with / in the name such as the command below. addc n/name/with/slash p/1233 e/124@124.124

Expected Behaviour: user profile as created. Actual behaviour: Error is shown. image.png

[original: nus-cs2103-AY2324S1/pe-interim#2551] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

It is in the documentation that we do not allow special characters. This is because the '/' may interfere with the parsing of inputs.

Users can make use of the remark field to specify that there is a missing slash in the contact name, if needed.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]