shyiko / electron-har

A command-line tool for generating HTTP Archive (HAR) (based on Electron)
https://www.npmjs.com/package/electron-har
MIT License
47 stars 11 forks source link

Add network throttling and device user agent configs #6

Open bmcminn opened 8 years ago

bmcminn commented 8 years ago

Fix #5

EDIT:

shyiko commented 8 years ago

Good work! Would you mind removing console.log calls and rebase the branch (right now I can't merge it in due to "This branch has conflicts that must be resolved")?

Also, where does src/profiles/devices.js & src/profiles/networks.js data come from? Thank you.

bmcminn commented 8 years ago

Alright, finally got the rebase worked out.

Also, the src/profiles data was extrapolated from the latest Chrome throttling and UA device configs in dev tools.

shyiko commented 8 years ago

I propose we take list of devices from here. What do you think?

shyiko commented 8 years ago

Also, download/upload throttling is calculated differently. See here.

bmcminn commented 8 years ago

I like that idea. Just added those defs verbatim to src/profiles/devices.js.

I also went ahead and fixed up a few other things and updated the PR description. I think this feature is ready to close now.

shyiko commented 8 years ago

Hey man. Unfortunately it looks like this PR will have to wait. My laptop won't turn on :) Will get back to it as soon as I have it fixed.

bmcminn commented 8 years ago

Hey @shyiko any update on your laptop situation?

shyiko commented 8 years ago

@bmcminn I'm getting it back tomorrow morning.