Open bmcminn opened 8 years ago
Good work! Would you mind removing console.log calls and rebase the branch (right now I can't merge it in due to "This branch has conflicts that must be resolved")?
Also, where does src/profiles/devices.js & src/profiles/networks.js data come from? Thank you.
Alright, finally got the rebase worked out.
Also, the src/profiles
data was extrapolated from the latest Chrome throttling and UA device configs in dev tools.
I like that idea. Just added those defs verbatim to src/profiles/devices.js
.
I also went ahead and fixed up a few other things and updated the PR description. I think this feature is ready to close now.
Hey man. Unfortunately it looks like this PR will have to wait. My laptop won't turn on :) Will get back to it as soon as I have it fixed.
Hey @shyiko any update on your laptop situation?
@bmcminn I'm getting it back tomorrow morning.
Fix #5
EDIT:
-A
(user agent) with argument validation-Y
(network throttling) with argument validationuser-agent
string override when using-A
--landscape
which forces device orientation to landscapesrc/profiles/devices.js
based on Chromium device profile definitions:src/profiles/networks.js
based on Chromium network speed definitions: