shyim / mail-mime-builder

RFC-2822, RFC-2045 and RFC-2049 compliant zero dependency raw email message generator
0 stars 0 forks source link

Error : Cannot find module ... #1

Closed jd-ucpa closed 1 week ago

jd-ucpa commented 1 month ago

Hi,

I'm using mail-mime-builder 0.1.0in es mode :

import { createMimeMessage } from 'mail-mime-builder'

It throw an error :

{
    "errorType": "Error",
    "errorMessage": "Cannot find module '/var/task/node_modules/mail-mime-builder/es/base64' imported from /var/task/node_modules/mail-mime-builder/es/MIMEMessage.js",
    "code": "ERR_MODULE_NOT_FOUND",
    "url": "file:///var/task/node_modules/mail-mime-builder/es/base64",
    "...": "..."
}

I resolve this issue by editing all the packages files in the node_modules directory and adding .js extension to some files :

The current exported file node_modules/mail-mime-builder/es/MIMEMessage.js throw this error :

// file : node_modules/mail-mime-builder/es/MIMEMessage.js
import { toBase64EncodeURI } from './base64';
import { MIMETextError } from './MIMETextError';
import { MIMEMessageHeader } from './MIMEMessageHeader';
import { Mailbox } from './Mailbox';
import { MIMEMessageContent } from './MIMEMessageContent';
export class MIMEMessage {
// ...

My updated version works :

import { toBase64EncodeURI } from './base64.js';
import { MIMETextError } from './MIMETextError.js';
import { MIMEMessageHeader } from './MIMEMessageHeader.js';
import { Mailbox } from './Mailbox.js';
import { MIMEMessageContent } from './MIMEMessageContent.js';
export class MIMEMessage {
// ...

Sometimes you use extesion and sometimes you don't :

https://github.com/shyim/mail-mime-builder/blob/main/src/MIMEMessageHeader.ts#L1-L5

import type {HeaderField} from './types'
import {toBase64} from './base64'

import {MIMETextError} from './MIMETextError.js'
import {Mailbox} from './Mailbox.js'

Thank you

shyim commented 1 month ago

weird the typescript compiler should unify it https://github.com/shyim/mail-mime-builder/blob/main/package.json#L19-L21

it will take a look later

shyim commented 1 week ago

Is fixed now sorryy that it too so long

jd-ucpa commented 1 week ago

Great ! Thank you !