search

shyim / op-gg-remove-ads

Removes ads from OP.GG client
52 stars 1 forks source link

not working after update #10

Closed gutaewoo closed 1 year ago

gutaewoo commented 1 year ago

not working after opgg update ...

op-gg-remove-ads update plz

MidKnightXI commented 1 year ago

The directory that was specified in the code where the ads were(assets/react) got removed and got replaced by a main directory containing main.js and preload.js.

Im still looking into it to find where the ad links are located with that new update but I guess we will have to work with that assets/main directory.

shyim commented 1 year ago

@MidKnightXI if your project works, I can archive this here :). makes no sense to have 2 projects doing same

MidKnightXI commented 1 year ago

@MidKnightXI if your project works, I can archive this here :). makes no sense to have 2 projects doing same

I can't work on the project atm because I don't have access to a windows machine(I'm on macOS) and the update is still not released on this platform.

My only way of working on it is through a VM and it's just sucking my laptop's battery and the performances are horrible when I'm building my project on it ...

So until OPGG release its update on macOS I think it's better if you can try to find a fix if you have time to.

shyim commented 1 year ago

I will have a look and fix it. Have vacatation this week and bought the league pass :D

MidKnightXI commented 1 year ago

Thank you so much man, have some nice vacation 🙏🏻

shyim commented 1 year ago

I would say try out https://github.com/shyim/op-gg-remove-ads/releases/tag/0.2.2

image

The ad placeholders are still there, but they are not displayed. OP.GG is so evil to read chrome cookies 🙈

MidKnightXI commented 1 year ago
image

Not working on my side with 0.2.2

shyim commented 1 year ago

I will take a look again. I guess i figured out why I have never ads. It's my local Adguard Home 🤣

shyim commented 1 year ago

With the last tagged version it really works. Now I have to take a bath to get rid of this dirt on me.

Feel free to use my Cloudflare Worker too.

For the context:

They remove their complete frontend code and host it now on their own cdn. So we can't remove it locally anymore. First ideas was to add https://github.com/ghostery/adblocker/tree/master/packages/adblocker-electron-example but it's really really instable to add this to the existing main.js

So I set up a own Cloudflare Worker which proxies their CDN and replaces it there