shyim / shopware-docker

Easy to use Docker Installation for Shopware 5 and Shopware 6
MIT License
115 stars 27 forks source link

add default shopware cdn strategy in .env #138

Closed zaifastafa closed 2 years ago

shyim commented 2 years ago

why is this needed?

zaifastafa commented 2 years ago

why is this needed?

I have seen several shops that we clone for local development has this CDN strategy in their .env file but our setup does not create this variable when setting up a shop, so thought it'd be good for consistency.

shyim commented 2 years ago

The argument works also in other way 😅

Maybe define in that projects this explict in the config/services.xml

zaifastafa commented 2 years ago

So this is not needed in your opinion? Without this variable, the media images show broken in the shop if we have done a clone.

zaifastafa commented 2 years ago

I have verified it that when I remove this variable, the media images are broken. But when I add it, it is able to identify the path of the images correctly.

shyim commented 2 years ago

I guess the production system have a configuration like this in the config/packages https://github.com/shopware/production/blob/6.4/config/services/defaults.xml#L19-L20

zaifastafa commented 2 years ago

Here it defaults to physical_filename, but I saw in a commit I think that it was defaulting to id in the yaml file, so I suppose we can use the default cdn strategy to be id here too? That is easier to maintain I think then changing the yaml file for local setups.