search

shyim / shopware-docker

Easy to use Docker Installation for Shopware 5 and Shopware 6
MIT License
115 stars 27 forks source link

Installation of 6.3.5.4 fails with SHOPWARE_INSTALL=1 #142

Closed daniel-memo-ict closed 2 years ago

daniel-memo-ict commented 2 years ago

Describe the bug Recently updated swdc to the latest master. Now when I try installing an older version, for example 6.3.5.4, the migrations fail at a certain point, stating that "MigrationStep::isInstallation should return bool, string returned" Commenting out https://github.com/shyim/shopware-docker/blob/master/modules/platform/build.sh#L34 restores functionality.

I've noticed that v1 is now the default branch, and I will switch to that one. This line does not yet appear to be in that branch, and I'm not sure if it will be added in the future. But just a heads-up that this will fail installation of (slightly) older Shopware versions.

To Reproduce Steps to reproduce the behavior:

  1. Clone shopware dev template
  2. Switch to v6.3.5.4 tag
  3. Do an swdc build

Expected behavior Migrations should execute normally

Screenshots image

Environment:

shyim commented 2 years ago

I am blind I can't find the SHOPWARE_INSTALL env in the project here set 🤔

daniel-memo-ict commented 2 years ago

It's currently only in the master branch, not in v1.

https://github.com/shyim/shopware-docker/blob/master/modules/platform/build.sh#L34

If I comment out that line everything works normally.

shyim commented 2 years ago

Use v1. I forgot to delete the master

daniel-memo-ict commented 2 years ago

:laughing: All good, I'll let everyone here know to use v1. But why not merge that into master, if that is the new version?