shyim / shopware-docker

Easy to use Docker Installation for Shopware 5 and Shopware 6
MIT License
115 stars 27 forks source link

Dashes in project name might create issues. #159

Closed rvveber closed 1 year ago

rvveber commented 2 years ago

Reproduce:

mysql error: -demo not found.

rvveber commented 2 years ago

Also it's impossible to reference FOLDER_NAME in ENV Vars if they have dashes in them

shyim commented 2 years ago

I guess normalizing to underscore would work 🤔

rvveber commented 2 years ago

Problem is just, that underscore characters are not permitted in domain names in accordance with RFC 1035, which only allows letters, digits and hyphens. This creates problems with e.g. chromes internal password filling, as it is not able to recognize a URL with an underscore.

shyim commented 2 years ago

EWWWWWWWWWWW

so when a folder contains underscore we have to rewrite it to minus when a folder contains minus the env has to be underscore

rvveber commented 2 years ago

🤣🤣 Yeah, major turn off

swsrmes commented 2 years ago

@color-space On the current v1 branch I don't have this issue any more

srmes ~swdc-dev (v1 !?) % swdc snap shopware-blank                     
mysqldump: [Warning] Using a password on the command line interface can be insecure.
srmes ~swdc-dev (v1 !?) %

Can this be closed?

shyim commented 1 year ago

I will close this then