If the zipfile is corrupt it should remove out from cache

shyim / store-plugin-installer

Install store.shopware.com Plugins automatically in your Shopware Composer Setup

36 stars 7 forks source link

If the zipfile is corrupt it should remove out from cache #16

Closed Forestsoft-de closed 5 years ago

Forestsoft-de commented 5 years ago

Its not possible to fix it if you dont know that there is a cache. Corrupt zipfiles shouldnt be cached.

Btw: Unittests for complete LocalCache class. The Plugininstaller private methods makes it impossibe to unit test. The verification that cacheclear is called in case of exception is missed.

shyim commented 5 years ago

Can you also rebase, i have merged your another PR

shyim commented 5 years ago

Thanks :)