search

shymega / RSSingle

Merge multiple feeds (RSS/Atom/JSON) into a single RSS feed.
Apache License 2.0
14 stars 3 forks source link

Fix format error #18

Closed tanrax closed 10 months ago

tanrax commented 1 year ago

@shymega Fix the bug https://github.com/tanrax/RSSingle/issues/17

shymega commented 1 year ago

Good catch. I guess I only thought of KeyError as an Exception subclass there. The only thing I'd add is that this PR appears to change multiple things, making it hard to track down future bugs. Maybe splitting the changes into a PR each would be better? Up to you - otherwise, good catch on my previous oversight! :+1:

shymega commented 1 year ago

OK, after some rebasing, I've adjusted the PR. I've also done this to #16, to make it one change per PR.

What formatting tool did you use? What would be a good plan, is to branch from master, run the linter, and then make a PR. Otherwise, branching from feature or bug-fix PRs includes commits that aren't necessarily related to the PR.

(Heads-up: this has been force-pushed, so you'll need to do a git pull --rebase)

shymega commented 1 year ago

The only thing left to change in this PR is to split the 'format string' change, and the Exception catch change. I will leave that to you because I'm conscious I might have overstepped my bounds.