shymmq / librus-client

Klient restowego API librusa na androida
https://play.google.com/store/apps/details?id=pl.librus.client
GNU General Public License v3.0
14 stars 3 forks source link

Make app compliant with F-Droid policy #73

Closed mimi89999 closed 7 years ago

mimi89999 commented 7 years ago

It would be nice to have this app in F-Droid. However, to be added, the app needs to be 100% free (including dependencies). I noticed the non-free com.google.gms library as a requirement. If it could be removed, it would be great.

xdk78 commented 7 years ago

Google GMS is used to making app better:

shymmq commented 7 years ago

@mimi89999 , unfortunately, this would mean removing real-time notifications which are one of the core components of our app

mimi89999 commented 7 years ago

There could be 2 variants of this app: one free for F-Droid and one with notifications.

As siacs/conversations is doing.

mimi89999 commented 7 years ago

I can make 2 productFlavors. How to call them?

mimi89999 commented 7 years ago

Ah, the foreign repo https://oss.sonatype.org/content/repositories/snapshots/ also has to be removed. That isn't a problem since eu.davidea:flexible-adapter:5.0.0-rc1 is also in the standard repo.

mimi89999 commented 7 years ago

But is needed for org.immutables:value:2.4.4-SNAPSHOT :P

shymmq commented 7 years ago

@rowysock ?

rowysock commented 7 years ago

We need immutables in version 2.4.4 because of this issue: https://github.com/immutables/immutables/issues/546. Maybe let's just wiat for the next immutables relese and then we could remove https://oss.sonatype.org/content/repositories/snapshots/ ?

mimi89999 commented 7 years ago

@rowysock Isn't it immutables/immutables#546

rowysock commented 7 years ago

@mimi89999 Yes, actually it is

mimi89999 commented 7 years ago

@shymmq please git tag all future releases with the same label as the app version name. It will allow F-Droid to automatically detect updates.