search

shyndman / flutter_layout_grid

A grid-based layout system for Flutter, inspired by CSS Grid Layout
MIT License
441 stars 43 forks source link

Migrate `example` to null safety, adopt `flutter_lints` #70

Closed domesticmouse closed 2 years ago

shyndman commented 2 years ago

Thanks! I'll take a look at this soon.

Don't worry about CI. I'll investigate that as well.

shyndman commented 2 years ago

So @domesticmouse, what's your thinking behind adopting flutter_lints project-wide?

domesticmouse commented 2 years ago

Looks like you have Flutter 2.2 as your CI SDK: https://github.com/shyndman/flutter_layout_grid/runs/5344619625?check_suite_focus=true#step:4:37

As for migrating from a copy of pedantic 1.8 rule set to flutter_lints, we deprecated pedantic for a reason. For Flutter code like this library, flutter_lints captures all of our best practices for both dart code and flutter api usage.

shyndman commented 2 years ago

Ah, got it.

So this is a bit too broadly applied for my liking. Want me to take over the PR, or go point by point?

shyndman commented 2 years ago

You know, I'd prefer to take over. I'll give you a few broad changes I'd like to see, but I'll handle the nits myself.

shyndman commented 2 years ago

Thanks @domesticmouse! 👍

shyndman commented 2 years ago

Published as v1.0.5