shyndman / pubx

The missing pub commands
Apache License 2.0
35 stars 3 forks source link

Figure out how we want add to treat existing path and git dependencies #12

Open shyndman opened 5 years ago

shyndman commented 5 years ago

My feeling is we should probably ignore them with a warning.

Vanethos commented 5 years ago

So, you are saying that if a user has a git or path dependency and wants to add the dependency?

What if the user wants to force adding the dependency, and delete the git/path part?

shyndman commented 5 years ago

It's two things:

  1. Testing that what we have now will correctly overwrite a git/path dependency. I think it will, but haven't tried.
  2. Determine whether that's the behavior we want. Maybe we do?

On Mon, Aug 5, 2019 at 3:17 PM Gonçalo Palma notifications@github.com wrote:

So, you are saying that if a user has a git or path dependency and wants to add the dependency?

What if the user wants to force adding the dependency, and delete the git/path part?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/shyndman/pubx/issues/12?email_source=notifications&email_token=AAAKKVSBKQB3BZNPNGKXQFDQDCRFZA5CNFSM4IJOW6PKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3TH5QI#issuecomment-518422209, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAKKVUMIVGPLG5HHRDYD6TQDCRFZANCNFSM4IJOW6PA .