shyzus / gnome-shell-extension-screen-autorotate

Enable screen rotation regardless of touch mode

GNU General Public License v3.0

31 stars 9 forks source link

17-fix-rotate #23

Closed BlackDuck888 closed 10 months ago

BlackDuck888 commented 10 months ago

I have made a change to the offset handling. Because a display only knows 4 orientations. An offset of +3 with an orientation of 3 would be 6 and that is not a reasonable value. Technically this is permissible but does not lead to a meaningful result. The solution is the modulo operator. In this case, negative values are no longer required. Whether you take -1 or 3 leads to the same result.

Unfortunately, it took a little longer because my Linux distribution has only now reached gnome 45. Should close #17

shyzus commented 10 months ago

Just tested it on my machine and everything seems to work as expected.

Thank you for your contribution @BlackDuck888 . I will add some additional changes such as updating the version before creating a new release.

System Details Report

Report details

Date generated: 2023-11-14 16:00:00

Hardware Information:

Hardware Model: Lenovo Lenovo IdeaPad C340-14API
Memory: 12.0 GiB
Processor: AMD Ryzen™ 5 3500U with Radeon™ Vega Mobile Gfx × 8
Graphics: AMD Radeon™ Vega 8 Graphics
Disk Capacity: 120 GiB

Software Information:

Firmware Version: AGCN28WW(V1.11)
OS Name: Fedora Linux 39.20231114.0 (Silverblue)
OS Build: (null)
OS Type: 64-bit
GNOME Version: 45.1
Windowing System: Wayland
Kernel Version: Linux 6.5.11-300.fc39.x86_64