shz9 / magenpy

Modeling and Analysis of (Statistical) Genetics data in python
https://shz9.github.io/magenpy/
MIT License
16 stars 5 forks source link

Re-organize the code for modularity #3

Closed shz9 closed 2 years ago

shz9 commented 2 years ago

Currently, the GWASDataLoader class incorporates many functionalities that make it brittle and harder to work with. We would like to move some of those functionalities into their own classes/objects.

Here are a number of ideas that we can implement:

In this sort of setup, the GWASDataLoader object would be an interface to harmonize these data classes, instead of performing many different, unrelated functions.

dorukcakmakci commented 2 years ago

While these changes make code more modular, development can get messy quickly. How about we write a test for GWASSimulator class to ensure it preserves its functionality before tackling this issue?

shz9 commented 2 years ago

Most of this refactoring was done in magenpy==0.0.2.