shzlw / poli

An easy-to-use BI server built for SQL lovers. Power data analysis in SQL and gain faster business insights.
https://shzlw.github.io/poli
MIT License
1.97k stars 331 forks source link

start.sh has DOS line endings #19

Closed mmessmore closed 5 years ago

mmessmore commented 5 years ago

It has newline + carriage return line endings. It should have Unix line endings since it is a shell script.

$ cat -vet start.sh
#!/bin/sh^M$
set -e^M$
^M$
java -jar poli-0.9.0.jar --spring.config.name=application,poli^M$
$ dos2unix start.sh
dos2unix: converting file start.sh to Unix format...
$ cat -e start.sh
#!/bin/sh$
set -vet$
$
java -jar poli-0.9.0.jar --spring.config.name=application,poli$
chr15m commented 5 years ago

Additionally the version of start.sh in the release is not executable - needs a chmod 755 start.sh in order to work. Since the version in the repository itself seems ok these both seem like build-time issues.

shzlw commented 5 years ago

Thanks for pointing those out. The line endings and the file permission are fixed in the new release now .