search

sialcasa / mvvmFX

an Application Framework for implementing the MVVM Pattern with JavaFX
Apache License 2.0
494 stars 105 forks source link

Maven dependency to ControlsFX for Validator module wrong #482

Closed manuel-mauky closed 7 years ago

manuel-mauky commented 7 years ago

Prior to version 1.6.0 the validator was part of the core mvvmFX maven module. One of the validator visualizers is using ControlsFX library. To not force users of the core module to include a dependency to ControlsFX the dependency was marked as <scope>provided</scope> in the maven POM.xml. A user of the visualizer would need to add ControlsFX by herself.

With version #459 which is part of version 1.6.0 we moved the validator into it's own package. However, with this transition the visibility of ControlsFX was changed to "compile" (default scope). This change was by mistake. The scope should still be provided even for the validator-module.

manuel-mauky commented 7 years ago

This issue fixes an API breaking change made by 1.6.0 version.