search

sialcasa / mvvmFX

an Application Framework for implementing the MVVM Pattern with JavaFX
Apache License 2.0
489 stars 104 forks source link

DelegateCommand cannot be extended #536

Closed ntherrien closed 6 years ago

ntherrien commented 6 years ago

The following fields are set as private:

private final Supplier<Action> actionSupplier;
private boolean inBackground;

Can we se all fields to a minimum of Protected so that we can extend the DelegateCommand class?

manuel-mauky commented 6 years ago

Thanks for the suggestion. Yes, I think this would be possible. At least I don't see any reason that would prevent us from doing this.

If you like, you can provide a PullRequest for this and I will merge it as fast as possible.

ntherrien commented 6 years ago

Hi! PullRequest has been submitted.

I have committed some changes on the project's develop branch by mistake. I have reverted that and moved my change to my fork and a separate branch.

Regards,

manuel-mauky commented 6 years ago

PR is merged. Thanks for the contribution