search

sialcasa / mvvmFX

an Application Framework for implementing the MVVM Pattern with JavaFX
Apache License 2.0
489 stars 104 forks source link

[#543] Incorrect exception message in ViewLoaderReflectionUtils #548

Closed nils-christian closed 6 years ago

nils-christian commented 6 years ago

This is a pull request for #543. I corrected the exception message as originally discussed. I also made sure that the ScopeProvider has value as an alias for scopes, which is handled in the ViewLoaderReflectionUtils. From the two view models in the example using a scope provider, one uses now scopes and the other one the value field.

manuel-mauky commented 6 years ago

Many thanks for your contribution. There is just a small issue I have: In the getScopesFromProvider method you are using some code formatting settings that don't match the rest of the code. You are using tabs instead of (4) spaces for indentation and you are placing spaces in method parentheses (i.e. someMethod( 42 ) instead of someMethod(42)).

It would be nice if you could fix that before I merge the PR.

We also have an eclipse formatter config but I have to admit that I'm not sure if it is used consistently across the whole code base and as I'm personally using IntelliJ instead of eclipse it's likely that I'm commiting code that doesn't match this config from time to time. I'm not fundamental with coding guidelines but I try to keep the basics like indentation as clean as possible.

nils-christian commented 6 years ago

Hi,

Sure. I corrected the indentation and removed the spaces before and after the parentheses. I also corrected a minor typo in the Javadoc.

Best regards

Nils