#538 Using ControlsFxVisualizer causes node graph inconsistencies

sialcasa / mvvmFX

an Application Framework for implementing the MVVM Pattern with JavaFX

Apache License 2.0

489 stars 104 forks source link

#538 Using ControlsFxVisualizer causes node graph inconsistencies #551

Closed ntherrien closed 6 years ago

ntherrien commented 6 years ago

The node graph problems are due to the fact the initialization code has not yet finished by the time new Validation overlays are created as nodes. Wrapping the code in a run later ensures initialization will complete before the visualization nodes are created.

ntherrien commented 6 years ago

@lestard I have re-created the pull request from a new branch. Removed the test class entirely because I don't have any more time on my hands. I stuck to the essential part which was fixing the bug.

manuel-mauky commented 6 years ago

Thanks for your help. I think it's ok this way without test because it is really hard to verifiy the original bad behavior that you've observed. The test would need to reproduce the mixed up scene-graph which would be really hard to reproduce in a test.