Add Tests for Java 9 Modules

sialcasa / mvvmFX

an Application Framework for implementing the MVVM Pattern with JavaFX

Apache License 2.0

489 stars 104 forks source link

Add Tests for Java 9 Modules #560

Open manuel-mauky opened 5 years ago

manuel-mauky commented 5 years ago

In PR #555 an issue was fixed that prevented users from using mvvmFX in Java 9 Modules because the FxmlViewLoader was using an internal class to load resources.

What is missing is a unit-test that proves that this solution is working now and wasn't working beforhand. This is imporant to be safe with refactorings and new features in the future.

manuel-mauky commented 5 years ago

With #562 we have added a working example project for modules with Java 11. However, due to the fact that the core mvvmfx library is compiled with Java 8 (which won't be changed in the near future) it's not yet possible to include an automated test for this.