Fix the Automatic-Module-Name for mvvmfx-validation

sialcasa / mvvmFX

an Application Framework for implementing the MVVM Pattern with JavaFX

Apache License 2.0

495 stars 104 forks source link

Fix the Automatic-Module-Name for mvvmfx-validation #588

Closed mokonzi131 closed 5 years ago

mokonzi131 commented 5 years ago

Module names should be valid package names (no hyphen characters allowed in this case). The current name with the hyphen causes a module-info.java file to fail to compile when you try to import this module.

See the spec https://cr.openjdk.java.net/~mr/jigsaw/spec/java-se-9-jls-diffs.pdf (page 192-193)

manuel-mauky commented 5 years ago

Thanks for this PR. The introduction of module names was a last-minute change and obviously I've missed this.