siara-cc / esp32_arduino_sqlite3_lib

Sqlite3 Arduino library for ESP32
Apache License 2.0
370 stars 66 forks source link

Arduino Library Manager #3

Closed tobozo closed 5 years ago

tobozo commented 5 years ago

hope you don't mind I made the request for you ^_^

https://github.com/arduino/Arduino/issues/8541

siara-cc commented 5 years ago

Wow.. thanks @tobozo .. I didn't know about it.. I hope many people use it..

tobozo commented 5 years ago

looks like it's passed the tests successfully \o/ it should land in the Library Manager in a couple of hours

tobozo commented 5 years ago

funny the platformio robot didn't find your project though, I've given it a little help:

$ pio lib register https://github.com/siara-cc/esp32_arduino_sqlite3_lib/raw/master/library.properties
The library has been successfully registered and is waiting for moderation
siara-cc commented 5 years ago

Many thanks @tobozo.. Can I request to add myself or only users can?

tobozo commented 5 years ago

I'm not a power user, anyone can request it

siara-cc commented 5 years ago

Yes!! It is on their website. But they seem to have taken the oldest release though!! Anyway, the link is there for anyone to upgrade. lib_mgr_ss

tobozo commented 5 years ago

that's another registry, platformio registry is that one: https://platformio.org/lib/search?query=sqlite3

actually I don't even know if this library works on platformio, but it's only a matter of adding a plaformio.ini with the correct -D flags (and the corresponding #ifdef's in the code)

siara-cc commented 5 years ago

yes, I have heard about PIO.. I haven't used it either..

tobozo commented 5 years ago

well I just tried to import it via pio lib install https://github.com/siara-cc/esp32_arduino_sqlite3_lib.git and it compiled the spiffs example just fine

tobozo commented 5 years ago

congrats !!!

image

tobozo commented 5 years ago

this will only make your releases available from the Library Manager, totally different from doing a git clone from the master

siara-cc commented 5 years ago

right.. GUI Frontend that will cover non-CLI users too.

tobozo commented 5 years ago

Actually the current release (0.9) does not compile on Arduino IDE (I had to overwrite the library folder with the current master source) so you may want to increment your version in library.properties, then create a tag and produce a release.

Platformio and Arduino library managers will automatically detect this release and send and add it to the versions list (no need to re-submit) as long as the library.properties version and release values match, and the version increments.

tobozo commented 5 years ago

And platformio coped with the new version https://platformio.org/lib/show/6173/Sqlite3Esp32 \o/

siara-cc commented 5 years ago

Excellent.. I also requested to add my other libraries on both platforms.. Thanks @tobozo ...