search

siavash79 / PixelXpert

mixed Xposed+Magisk module for customization of Google Pixel rom of Android 12+
GNU General Public License v3.0
1.77k stars 108 forks source link

Keeps clock text color consistent in QS header #153

Closed LuminarySage closed 2 years ago

LuminarySage commented 2 years ago

What's on your mind? Ensure the clock in QS header stays in sync with the rest of the text color Screenshot_20220512-213910

Is this feature implemented on any other app/mod/rom? please specify It was implemented on typhus/eltifo's Addon Features for Pixel Devices mod

siavash79 commented 2 years ago

It must be something else I guess. Because this mod never touches the clock color. On the contrary, in AOSPMods the clock color is used as the reference color for other stuff, such as battery bar and battery icon

LuminarySage commented 2 years ago

@siavash79 I'm not saying it's a bug caused by your mod. This is actually a bug in aosp bc I've had it on my device since updating to android 12 before I even root it again. I was just requesting that you mod it for consistency. This was fixed by @ElTifo in his addons mod like I said so I'm sure there's a way to do it

siavash79 commented 2 years ago

I see. Let me check more.

The important thing is to find a consistent reference to use for the correct color. then color errors can be fixed accordingly

Why is it tricky? Because so far the clock is the only thing that's always present in the statusbar. Other shapes and info can disappear on demand

LuminarySage commented 2 years ago

Maybe @ElTifo can chime in

LuminarySage commented 2 years ago

Also I need to mention that a systemUI restart fixes it, at least until device theme is switched or whenever a new color palette is applied, then it's pure white again

LuminarySage commented 2 years ago

Just an update on something new I found. Apparently, this isn't an issue at all if you have light QS enabled. Now I do wonder if this was the same case with @ElTifo's old mod since I enabled the light QS option all the time with his mod so maybe I just didn't notice?

EleoXDA commented 2 years ago

Did you check with the latest canary version?

siavash79 commented 2 years ago

Since this is a bug of ROM, it can't be covered by AOSPMods